bunqCommunity / bunqJSClient

A javascript SDK for the bunq API
MIT License
58 stars 23 forks source link

Fix parseOauthUser bug #59

Closed ExtraGG closed 4 years ago

ExtraGG commented 4 years ago

Save the useful UserApiKey instead of the UserPerson.id inside BunqJSClient.Session.userInfo["UserApiKey"]. The UserPerson.id couldn't be used to retrieve monetary accounts in the case of Oauth.

codecov[bot] commented 4 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          71       71           
  Lines        2221     2221           
  Branches      456      456           
=======================================
  Hits         2191     2191           
  Misses         29       29           
  Partials        1        1
Impacted Files Coverage Δ
src/BunqJSClient.ts 97.3% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34eec70...ff60239. Read the comment docs.