buo / homebrew-cask-upgrade

A command line tool for upgrading every outdated app installed by Homebrew Cask
MIT License
2.44k stars 90 forks source link

Rename module Hbc to Cask #114

Closed ondrejfuhrer closed 6 years ago

ondrejfuhrer commented 6 years ago

Fixes #113 Fixes #112 Fixes #117

v0rts commented 6 years ago

Thanks @ondrejfuhrer. Used your branch, works well 🥇

shanmuha commented 6 years ago

to use this fix for now , in /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade run git pull origin pull/114/head

julionc commented 6 years ago

cc: 👀 @buo

arturmartins commented 6 years ago

I did what @shanmuha said and it didn't work. Neither in https://travis-ci.org/buo/homebrew-cask-upgrade/jobs/425179206

arturmartins commented 6 years ago

localhost:homebrew-cask-upgrade user$ git pull origin pull/114/head

remote: Counting objects: 6, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 6 (delta 2), reused 4 (delta 0), pack-reused 0
Unpacking objects: 100% (6/6), done.
From https://github.com/buo/homebrew-cask-upgrade
 * branch            refs/pull/114/head -> FETCH_HEAD
Updating 7dbaa5f..6a826ca
Fast-forward
 lib/bcu.rb                     |  6 +++---
 lib/extend/{hbc.rb => cask.rb} | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)
 rename lib/extend/{hbc.rb => cask.rb} (85%)

localhost:homebrew-cask-upgrade user$ brew cu -a

Error: cannot load such file -- cask/all
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:4:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/cmd/brew-cu.rb:32:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/utils.rb:19:in `require?'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'
ondrejfuhrer commented 6 years ago

@arturmartins Thanks for the report, I guess the problem is with incompatible brew version, can you please run this and see if then it works for you?

cd $(brew --repo) && git fetch && git reset --hard origin/master && git pull origin master && cd -
jski commented 6 years ago

@ondrejfuhrer, I was having the same issue listed above, and your command gets it working again. Thanks!

arturmartins commented 6 years ago

@ondrejfuhrer: Running that command worked. My homebrew version was 1.7.2 (now 1.7.3).

Thanks.

seagle0128 commented 6 years ago

This fix works fine for me. Please merge it. Thanks.

johnbianchi commented 6 years ago

i tried the above fix does not work for me:


$ cd $(brew --repo) && git fetch && git reset --hard origin/master && git pull origin master && cd -

$ brew --version
Homebrew 1.7.3-102-g88e69f5
Homebrew/homebrew-core (git revision 612b; last commit 2018-09-11)
Homebrew/homebrew-cask (git revision 8c4d59f; last commit 2018-09-10)

$ brew cu
Error: uninitialized constant Hbc
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/extend/hbc.rb:3:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:6:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/cmd/brew-cu.rb:32:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/utils.rb:19:in `require?'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

nevermind, I added the first part and its fixed:
$ /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade
$ git pull origin pull/114/head
ondrejfuhrer commented 6 years ago

@johnbianchi yes you forgot the thing from here https://github.com/buo/homebrew-cask-upgrade/pull/114#issuecomment-419379489

@buo would be great if you merge it 🙏

rjcoelho commented 6 years ago

Whats holding the merge of this PR ?

jerryskye commented 6 years ago

@rjcoelho I think the only person with permissions to merge is @buo, the owner of the repository

star114 commented 6 years ago

@buo Please merge it!

ondrejfuhrer commented 6 years ago

Just a note here for everyone who used my branch and don't know how to get back, just execute this:

cd /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade && git fetch --all && git reset --hard && git checkout master && git pull && cd -
yurikoles commented 6 years ago

Or simply brew update-reset.