search

buo / homebrew-cask-upgrade

A command line tool for upgrading every outdated app installed by Homebrew Cask
MIT License
2.4k stars 90 forks source link

Shell-escape an argument to system #146

Closed ogham closed 4 years ago

ogham commented 4 years ago

Hi,

I tried my hand at fixing the issue I raised with the Ruby Shellwords module.

Thanks for making homebrew-cask-upgrade!

Commit message:

This commit fixes #145, where the version number argument was not being escaped before being passed to system, which resulted in a syntax error from sh if the version number contained punctuation or other shell characters.

ondrejfuhrer commented 4 years ago

Thank you for that 👍