search

buo / homebrew-cask-upgrade

A command line tool for upgrading every outdated app installed by Homebrew Cask
MIT License
2.4k stars 90 forks source link

Add batched update option for interactive mode #195

Closed XOR-op closed 1 year ago

XOR-op commented 2 years ago

This PR add support for batched update option for interactive mode.

To be specific, I add option b for each interaction. And for each app answered with b, I record it in a temporary list, then perform upgrade after all interactions are answered.

Fixes https://github.com/buo/homebrew-cask-upgrade/issues/182 (asks for the same feature enhancement)

ondrejfuhrer commented 2 years ago

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

XOR-op commented 2 years ago

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

You're right. However I have no experience in Ruby, so I'm not sure if I would break something in that manner. Also I've pushed a new commit to recover original flag.

ondrejfuhrer commented 1 year ago

Hey @XOR-op , I've come up with an alternative, where I first asks for the input and then execute it. Feel free to look into the solution or propose any changes (https://github.com/buo/homebrew-cask-upgrade/pull/224).

ondrejfuhrer commented 1 year ago

Closed in favour of #224