search

buo / homebrew-cask-upgrade

A command line tool for upgrading every outdated app installed by Homebrew Cask
MIT License
2.4k stars 90 forks source link

Fixes #95 #96

Closed goodwillcoding closed 6 years ago

goodwillcoding commented 6 years ago

Change Caskroom path retrieval due to changes in hbc/locations.rb

Hbc.caskroom was changed to Hbc::Caskroom.path here https://github.com/Homebrew/brew/commit/3d423b0587d54029cc60616d506318425c22e7a4#diff-7251741d14e538114958333ecce1e184L9
goodwillcoding commented 6 years ago

This should fix #95

GreyTeardrop commented 6 years ago

Thanks! This fixes issue for me.

goodwillcoding commented 6 years ago

@buo ping ... can we pull this PR in, cask-upgrade is completely broken without this fix as of June 9th

goodwillcoding commented 6 years ago

@ondrejfuhrer ping ... can we pull this PR in, cask-upgrade is completely broken without this fix as of June 9th

ondrejfuhrer commented 6 years ago

@goodwillcoding Thanks a lot for the PR, I was going to fix that myself and now I saw, that you already did, nice 👍 Unfortunatelly I cannot merge it, only @buo can AFAIK.

COOLIRON2311 commented 6 years ago

@goodwillcoding @ondrejfuhrer Doesn't work for me:

Homebrew 1.6.7-56-g9ebcef7 Homebrew/homebrew-core (git revision 78b07; last commit 2018-06-09)

bash-3.2$ brew cu
==> Options
Include auto-update (-a): false
Include latest (-f): false
==> Updating Homebrew
Already up-to-date.
==> Finding outdated apps
Error: uninitialized constant Hbc::CASKROOM
Did you mean?  Hbc::Caskroom
               Hbc::CaskError
               Hbc::Cask
               CaskLock
               CASROOM
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/extend/hbc.rb:7:in `installed_apps'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:66:in `find_outdated_apps'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:24:in `process'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/cmd/brew-cu.rb:34:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3_2/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3_2/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/utils.rb:18:in `require?'
/usr/local/Homebrew/Library/Homebrew/brew.rb:105:in `<main>'
ondrejfuhrer commented 6 years ago

@COOLIRON2311 You updated that yourself or changed to @goodwillcoding branch? Seems you have a typo there CASROOM instead of CASKROOM

goodwillcoding commented 6 years ago

@ondrejfuhrer bummer, not sure if @buo been around much to merge? thanks for responding

goodwillcoding commented 6 years ago

@COOLIRON2311 works fine, you have a typo CASROOM instead of CASKROOM

COOLIRON2311 commented 6 years ago

@goodwillcoding @ondrejfuhrer Thank you! All works fine now. A typo happened because I copy/pasted the line from #95.

marioleed commented 6 years ago

I had to do this as well: https://github.com/buo/homebrew-cask-upgrade/issues/97#issuecomment-396161489

cd "$(brew --repo)" && git fetch && git reset --hard origin/master && brew update