bupaverse / petrinetR

4 stars 0 forks source link

IDs displayed instead of labels #4

Closed jzicker closed 4 years ago

jzicker commented 4 years ago

I was able to get the simple example to run without issues except for the final render_PN call. The resulting graph displayed IDs instead of Labels

the transitions look like this... much different than the example pn$petrinet$transitions id label 1 skip_3 2 5206b1ce-0f6a-477b-907d-f462eb0480eb Blood test 3 ba589911-7d60-4a96-b627-0d2beb09534f Triage and Assessment 4 b6941ed6-e77c-40a3-ac2a-7d0b4d9a3dc7 MRI SCAN 5 071a9c6f-8b27-4953-9208-810775afcd9f Discuss Results 6 bc6bc5b0-bca2-43a4-8d7d-70c5c8fe8435 X-Ray 7 0cd8379a-d82b-49a6-b6a4-02141e55be75 Registration 8 878cb56a-9c24-412d-a59b-f7064827fb48 Check-out 9 skip_2 10 skip_1

fmannhardt commented 4 years ago

I assume that you refer to the pm4py package instead of bupaR? Can you provide a full, reproducible example of what you tried? Along with the output of sessionInfo()

gertjanssenswillen commented 4 years ago

Transfer the issue to pm4py, but might also be related to petrinet package

fmannhardt commented 4 years ago

I could reproduce this issue with the current pm4py version and currently release petrinetR package. Code to reproduce:

library(pm4py)
library(bupaR)

patients_completes <- patients[patients$registration_type == "complete", ]
pn <- discovery_inductive(patients_completes) 
render_PN(pn$petrinet)

I think this is related to missing support for labels here: https://github.com/bupaverse/petrinetR/issues/1 and that pm4py started to use UUIDs for transitions.

Moving this to petrinetR.