bupaverse / processanimateR

Token replay animation for process maps created with processmapR by using SVG animations (SMIL) and the htmlwidget package.
https://bupaverse.github.io/processanimateR/
Other
66 stars 11 forks source link

Performance regression in Chrome pre-80 #23

Closed fmannhardt closed 4 years ago

fmannhardt commented 4 years ago

The performance of the token animation is very slow in the current Chrome build. For example, the following code wrong the vignette is painfully slow:

library(processanimateR)
library(dplyr)
library(bupaR)
animate_process(sample_n(traffic_fines, 1000) %>% filter_trace_frequency(percentage = 0.95),
                mode = "relative",
                legend = "color", 
                mapping = token_aes(color = token_scale("amount", 
                                                        scale = "linear", 
                                                        range = c("yellow","red"))))
fmannhardt commented 4 years ago

This seems to be caused by a severe SVG SMIL animation performance regression in Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=983594&can=1&q=svg%20performance%20smil&sort=-modified&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

This was fixed in: https://chromium.googlesource.com/chromium/src.git/+/415b09c7cc09f38efab07f754e2a41d437b7f060

In the current beta version of Chrome 80.0.3987.42 the performance is fine again. Logged this issue to help people that have the same issue. Simply wait for a new Chrome version :-)

fmannhardt commented 4 years ago

Going to close this once it works fine again in the officially released Chrome.