search

bupt-william / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Uninitialized data member causes dropped ICE candidates #322

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Due to the uninitialized bool Transport::allow_local_ips variable the 
Transport::VerifyCandidate(const Candidate*, ParseError *) reports error based 
on containing garbage.

Obviously, we can call Transport::set_allow_local_ips(bool) to ensure the 
deterministic behavior. However, excluding this case the local candidates are 
accepted randomly.

version. libjingle-0.6.14

Related class: Transport in the talk/p2p/base/Transport.h file.

Original issue reported on code.google.com by Bella.Ga...@gmail.com on 12 Mar 2012 at 2:25

GoogleCodeExporter commented 9 years ago 
The allow_local_ips_ variable is initialized in the Transport class' 
constructor initialization list as set to false.  This seems to be the 
reasonable default case.  The comments in transport.h for the setter and getter 
methods for this data member suggest setting it to true is only useful for 
testing:

// (For testing purposes only.)  This indicates whether we will allow local
  // IPs (e.g. 127.*) to be used as addresses for P2P.

Original comment by dlewa...@connectify.me on 13 Mar 2012 at 3:45

GoogleCodeExporter commented 9 years ago

Original comment by juberti@google.com on 31 May 2013 at 3:53