Support for Mac M1? - Githubissues

bupticybee / TexasSolver

🚀 A very efficient Texas Holdem GTO solver :spades::hearts::clubs::diamonds:

https://bupticybee.github.io/texassolver_page

GNU Affero General Public License v3.0

1.73k stars 306 forks source link

Support for Mac M1? #126

Open Andrewzhang217 opened 2 years ago

Andrewzhang217 commented 2 years ago

Hi, has console version been tested on Mac with M1 chip? It seems that it can not build on my machine with some linking errors

bupticybee commented 2 years ago

Hi, has console version been tested on Mac with M1 chip? It seems that it can not build on my machine with some linking errors

Actually no, I don't have an target machine, If you are interested, you can try compile from source.

Andrewzhang217 commented 2 years ago

Hi, has console version been tested on Mac with M1 chip? It seems that it can not build on my machine with some linking errors

Actually no, I don't have an target machine, If you are interested, you can try compile from source.

Thank you for your reply! I was actually compiling from the source code on console branch and it seems that it has some issues with fmt.h and could not build. At first, it has issues with omp.h as well but I think omp is not extensively used in your code base so I guess that one does not matter.

bupticybee commented 2 years ago

Hi, has console version been tested on Mac with M1 chip? It seems that it can not build on my machine with some linking errors

Actually no, I don't have an target machine, If you are interested, you can try compile from source.

Thank you for your reply! I was actually compiling from the source code on console branch and it seems that it has some issues with fmt.h and could not build. At first, it has issues with omp.h as well but I think omp is not extensively used in your code base so I guess that one does not matter.

Actually, omp is used, it's multi thread feature is core to this program. So I would suggest use compiler that supports omp to compile the program.

darrenmhill commented 2 years ago

Has anyone managed to build this on ARM64/M1 yet?

imre-kerr commented 1 year ago

Got it built, here's what I had to do:

Install llvm through brew

Tell cmake to use that:

export CC=/opt/homebrew/opt/llvm/bin/clang
export CXX=/opt/homebrew/opt/llvm/bin/clang++
export LDFLAGS="-L/opt/homebrew/opt/llvm/lib"
export CPPFLAGS="-I/opt/homebrew/opt/llvm/include"

Tell it where to find the standard lib:

export LIBRARY_PATH="$LIBRARY_PATH:/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib"

cmake -> make

bupticybee commented 1 year ago

Has anyone managed to build this on ARM64/M1 yet?

You can try to solve your problem the way @imre-kerr did.

Tokarak commented 8 months ago

It would be nice to have a universal mac binary distributed (as well as a fresh 0.2.1 release). I see the github workflow only supports an AppImage?

bupticybee commented 8 months ago

It would be nice to have a universal mac binary distributed (as well as a fresh 0.2.1 release). I see the github workflow only supports an AppImage?

But I don't have an mac M1 machine.