bupticybee / TexasSolver

🚀 A very efficient Texas Holdem GTO solver :spades::hearts::clubs::diamonds:
https://bupticybee.github.io/texassolver_page
GNU Affero General Public License v3.0
1.65k stars 295 forks source link

Miscellaneous Crashes #151

Open maxflores opened 1 year ago

maxflores commented 1 year ago

Frequently when i click "Start solving" the Mac OS X app just crashes. This is not a function of the parameters or of forgetting the build the tree since the same steps when reproduced sometimes do not crash.

bupticybee commented 1 year ago

You need to hit "build tree" before start solving.

maxflores commented 1 year ago

i do this every time and still get crashes

On Sun, Dec 18, 2022 at 8:47 PM icybee @.***> wrote:

You need to hit "build tree" before start solving.

— Reply to this email directly, view it on GitHub https://github.com/bupticybee/TexasSolver/issues/151#issuecomment-1357010194, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXGDSWOQL4VK43SOBFTX4DWN7EFRANCNFSM6AAAAAATBL4Q74 . You are receiving this because you authored the thread.Message ID: @.***>

bupticybee commented 1 year ago

i do this every time and still get crashes On Sun, Dec 18, 2022 at 8:47 PM icybee @.> wrote: You need to hit "build tree" before start solving. — Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXGDSWOQL4VK43SOBFTX4DWN7EFRANCNFSM6AAAAAATBL4Q74 . You are receiving this because you authored the thread.Message ID: @.>

Hmm that is very wired. Did you wait the compair file to load before hitting those buttoms?

截屏2022-12-19 上午10 50 16

You should always wait for the file to load before solving.

bupticybee commented 1 year ago

Here is a "normal" log should look like:

Loading holdem compairing file
Loading shortdeck compairing file
Loading finished. Good to go.
building tree..
build tree finished
Estimating tree memory..
Estimated Memory Usage: 1.33 Gb
Start Solving..
Using 8 threads
Iter: 0
player 0 exploitability 43.9384
player 1 exploitability 27.9392
Total exploitability 71.8775 precent
-------------------
Iter: 11
player 0 exploitability 15.3748
player 1 exploitability 2.73605
Total exploitability 18.1108 precent
time used:  6.857  second.
-------------------
Iter: 21
player 0 exploitability 10.7522
player 1 exploitability -2.31214
Total exploitability 8.44002 precent
time used:  14.762  second.
bupticybee commented 1 year ago

Would you show me the log before crash?

maxflores commented 1 year ago

this happens after setting all the parameters so i assume the file had loaded by then. i will continue using the solver and provide a log next time it happens

bupticybee commented 1 year ago

If it don't crash everytime, It works as excepted. I'm afraid the mac version is somehow unstable, windows version don't have the problem.

maxflores commented 1 year ago

it doesn't crash every time. here is a simple log not sure this helps. i noticed the crashes happen more often if i import a parameter file i previously saved or if i stop solving, change the parameters, and restart.

the crash happens immediately when clicking "start solving". cannot predict when it will happen or reproduce it consistently.

Screenshot 2022-12-19 at 10 45 39 PM
bupticybee commented 1 year ago

it doesn't crash every time. here is a simple log not sure this helps. i noticed the crashes happen more often if i import a parameter file i previously saved or if i stop solving, change the parameters, and restart.

the crash happens immediately when clicking "start solving". cannot predict when it will happen or reproduce it consistently.

Screenshot 2022-12-19 at 10 45 39 PM

Yeah that helps a little bit, if it didn't happen everytime, I'm afraid it works as excepted, there are some bug in macos I just can't catch.

maxflores commented 1 year ago

perhaps as a temporary workaround the solver can maintain the current state in a file so that when reopening you don’t lose all the parameters you’ve set.

for now i have to save every time before clicking start solving in case of a crash

On Tue, Dec 20, 2022 at 12:24 AM icybee @.***> wrote:

it doesn't crash every time. here is a simple log not sure this helps. i noticed the crashes happen more often if i import a parameter file i previously saved or if i stop solving, change the parameters, and restart.

the crash happens immediately when clicking "start solving". cannot predict when it will happen or reproduce it consistently. [image: Screenshot 2022-12-19 at 10 45 39 PM] https://user-images.githubusercontent.com/15622602/208587275-d2debabf-12a0-4efe-9251-65316bbe7790.png

Yeah that helps a little bit, if it didn't happen everytime, I'm afraid it works as excepted, there are some bug in macos I just can't catch.

— Reply to this email directly, view it on GitHub https://github.com/bupticybee/TexasSolver/issues/151#issuecomment-1358894638, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXGDSVONSDIHC6LXW3UC3LWOFGLJANCNFSM6AAAAAATBL4Q74 . You are receiving this because you authored the thread.Message ID: @.***>

bupticybee commented 1 year ago

perhaps as a temporary workaround the solver can maintain the current state in a file so that when reopening you don’t lose all the parameters you’ve set. for now i have to save every time before clicking start solving in case of a crash

Thanks for the suggestion!

LitoFrame commented 1 year ago

I have the same problem. The app crashes about in 1 of 4-6 times when I push the start solving button.