search

bupticybee / TexasSolver

🚀 A very efficient Texas Holdem GTO solver :spades::hearts::clubs::diamonds:
https://bupticybee.github.io/texassolver_page
GNU Affero General Public License v3.0
1.65k stars 295 forks source link

Same content for both if & else #172

Open siarheisinelnikau opened 1 year ago

siarheisinelnikau commented 1 year ago

@bupticybee there might be an issue:

https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/src/solver/PCfrSolver.cpp#L267

bupticybee commented 1 year ago

Hi, the code is there,yes, but it's not used in any way. Warmup just don't work as I excepted.

And the code was written two yeas ago, I don't know what these lines does anyways. If you have any idea where it's wrong, could you create a PR or describe it in detail?

siarheisinelnikau commented 1 year ago

Thanks for quick response.

I'm just trying to understand the overall logic of what is going on there, so don't know how to change it correctly either (yet!). Seems that PCfrSolver is very similar to BestResponse class, so it more looks like "copy/paste" issue.

bupticybee commented 1 year ago

Thanks for quick response.

I'm just trying to understand the overall logic of what is going on there, so don't know how to change it correctly either (yet!). Seems that PCfrSolver is very similar to BestResponse class, so it more looks like "copy/paste" issue.

Okay, that code you mentioned is a logic for a experimental feature(warmup). That feature is not active in current release.