search

bupticybee / TexasSolver

🚀 A very efficient Texas Holdem GTO solver :spades::hearts::clubs::diamonds:
https://bupticybee.github.io/texassolver_page
GNU Affero General Public License v3.0
1.71k stars 304 forks source link

Add Github Action (current failing in test step) #36

Closed Endle closed 3 years ago

bupticybee commented 3 years ago

I will look in to the error in ci, thanks for the contribution~

Endle commented 3 years ago

BTW @bupticybee do you interest in using the build matrix in windows, mac and Linux? I had a try but failed when setting up the build env. If so, I can spend a bit more time on it

bupticybee commented 3 years ago

BTW @bupticybee do you interest in using the build matrix in windows, mac and Linux? I had a try but failed when setting up the build env. If so, I can spend a bit more time on it

I checked the error, I already have an idea what's could be wrong in the ci process.

BTW, I believe the correct gramma is " are you interest in ...." not "do you interest in ..." haha

Anyway, In normal ci process I remember there is already a way to run things (build, release,etc) in parallel. I take a few look in the build matrix document, it didn't mention anything about multiplatform compile stuff, I mean in order to do that at least you should specific docker image or something like that, but Is there a image for Windows or Mac? I'm not sure.

Endle commented 3 years ago

BTW, I believe the correct gramma is " are you interest in ...." not "do you interest in ..." haha

Nice catch :)

Anyway, In normal ci process I remember there is already a way to run things (build, release,etc) in parallel. I take a few look in the build matrix document, it didn't mention anything about multiplatform compile stuff, I mean in order to do that at least you should specific docker image or something like that, but Is there a image for Windows or Mac? I'm not sure.

Well, it's easy to set up multi-platform with GIthub Action. Just change it to

os: [ubuntu-latest, macos-latest]

or adding windows platform as well. I'm done it in several personal projects, e.g.

This page lists the virtual environments provided by GIthub Action: https://github.com/actions/virtual-environments

bupticybee commented 3 years ago

BTW, I believe the correct gramma is " are you interest in ...." not "do you interest in ..." haha

Nice catch :)

Anyway, In normal ci process I remember there is already a way to run things (build, release,etc) in parallel. I take a few look in the build matrix document, it didn't mention anything about multiplatform compile stuff, I mean in order to do that at least you should specific docker image or something like that, but Is there a image for Windows or Mac? I'm not sure.

Well, it's easy to set up multi-platform with GIthub Action. Just change it to

os: [ubuntu-latest, macos-latest]

or adding windows platform as well. I'm done it in several personal projects, e.g.

This page lists the virtual environments provided by GIthub Action: https://github.com/actions/virtual-environments

Seems quite nice,I definitely am going to look into this. If you got the time, you are very welcome to contribute too.

bupticybee commented 3 years ago

Already done merging, and ci is all correct in master now