search

bupticybee / TexasSolver

🚀 A very efficient Texas Holdem GTO solver :spades::hearts::clubs::diamonds:
https://bupticybee.github.io/texassolver_page
GNU Affero General Public License v3.0
1.69k stars 301 forks source link

Isomorphic suits not converging to similar values #72

Open Bynoo opened 2 years ago

Bynoo commented 2 years ago

The used ranges are for 6-max, BTN open 2.5bb, BB 11bb, BTN calls. In this example, AcJc, AdJd, and AsJs are virtually the same hand on JhTh4h flop. However, the preferred strategy for them is not similar enough.

suits_bug

This leads to further imbalance between suits in later parts of the game tree, as can be seen in OOP's strategy when facing a bet of 15. Here, the strategies for isomorphic 8c8h, 8d8h, 8h8s do not agree - 8h8s is never raised, the other two combinations are raised 15.2% of the time.

suits_bug2

bupticybee commented 2 years ago

This is a know bug, when three board card has the same suit this bug will appear. For now you can uncheck the "use isomorphism" option, which will solve the problem, but this would slow the program a bit.

I will look into this bug when I got the time.

bupticybee commented 2 years ago

Also, when using isomorphism, it always throws here

https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/include/tools/utils.h#L22

which was called from

https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/src/solver/PCfrSolver.cpp#L376

I thought it might help solve isomorphism issue. what paper/algorithm is findGameSpecificIsomorphisms() function based on?

https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/src/solver/PCfrSolver.cpp#L691

Could you provide the config file? It would help a lot.

ad-dev-on commented 2 years ago

Of course TexasSolverConfig.txt

good thing you've quoted my comment, I wanted to edit it to add this line that it was called from here as well. but I accidentally deleted it. https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/src/solver/BestResponse.cpp#L212

bupticybee commented 2 years ago

Of course TexasSolverConfig.txt

good thing you've quoted my comment, I wanted to edit it to add this line that it was called from here as well. but I accidentally deleted it.

https://github.com/bupticybee/TexasSolver/blob/02e52e4bb47473d2854626f8c19f26e698c73347/src/solver/BestResponse.cpp#L212

Great, I will check this soon.