search

bupy7 / yii2-activerecord-history

This extension adds storage history of changes to the ActiveRecord model.
26 stars 17 forks source link

Fixed #3, applied DRY #4

Closed Eseperio closed 6 years ago

Eseperio commented 6 years ago

Fixes a problem when other behaviors use an expression as value. Also DRY has been applied to the behavior.

bupy7 commented 6 years ago

Thanks for your contribution, its cool, but I cannot merge its because of too much changes. It need tests. Could you please make another pull-request only for the skip attributes to merge it? DRY I will check not quick (I have much work). Or, you can add the tests for it (Codeception or PHPUnit as you want).

Eseperio commented 6 years ago

Nothing has changed on the data structure. The only thing that changes is that entity array data was defined almost equal in all cases of the switch statement. Now data its defined before switch statement, and then, on each switch case those parameters that really change (event, old_value, new_value...) are defined. It seems really messy on github code comparison, but functionality has not changed.

bupy7 commented 6 years ago

Could you please upgrade your pull-request and send its again?

bupy7 commented 6 years ago

Closed by cause have not activity.