buqiyuan / vite-vue3-lowcode

vue3.x + vite2.x + vant + element-plus H5移动端低代码平台 lowcode 可视化拖拽 可视化编辑器 visual editor 类似易企秀的H5制作、建站工具、可视化搭建工具
https://buqiyuan.github.io/vite-vue3-lowcode
MIT License
3.19k stars 777 forks source link

fix: augment `vue` rather than `@vue/runtime-core` #38

Open danielroe opened 3 months ago

danielroe commented 3 months ago

For a while, in the Vue ecosystem we've been augmenting @vue/runtime-core to add custom properties and more to vue. However, this inadvertently breaks the types for projects that augment vue - which is (now?) the officially recommended in the docs way to augment these interfaces (for example, ComponentCustomProperties, GlobalComponents and so on).

This means all libraries must update their code (or it will break the types of the libraries that augment vue instead).

Here's an example of how the augmented types end up broken.

This PR is a small effort to ensure the ecosystem is consistent. For context, you can see that vue-router has moved to do this, as well as Nuxt.

vercel[bot] commented 3 months ago

@danielroe is attempting to deploy a commit to the buqiyuan's projects Team on Vercel.

A member of the Team first needs to authorize it.

liaozhihao666 commented 3 months ago

这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。