Add datetime params begin/end to GetTransactions methods

burakoner / OKEx.Net

Open source .Net API wrapper for the @OKEx V5 Rest API and V5 Websocket API

MIT License

86 stars 48 forks source link

Add datetime params begin/end to GetTransactions methods #89

Closed SlavaTT closed 1 year ago

SlavaTT commented 1 year ago

Adding begin/end date time params to GetTransactionHistory/Archive methods

burakoner commented 1 year ago

Hi,

Thanks for your contribution. There are many endpoints that takes "before" "after" parameters. So you're absolutely right on this commit. But I cant accept this pull request, because I think it is not the best way to accept both epoch and datetime values as parameter. I'm developing a second OKX Api Wrapper nowadays. I'm adding overrided methods for this kind of endpoints. I'll implement this commit to that wrapper.

Have a nice day