buraksezer / consistent

Consistent hashing with bounded loads in Golang
https://research.googleblog.com/2017/04/consistent-hashing-with-bounded-loads.html
MIT License
693 stars 69 forks source link

Add receive a memeber but Remove receive a string #18

Closed halfcrazy closed 3 years ago

halfcrazy commented 3 years ago
// Add adds a new member to the consistent hash circle.
func (c *Consistent) Add(member Member) {
}

// Remove removes a member from the consistent hash circle.
func (c *Consistent) Remove(name string) {
}
buraksezer commented 3 years ago

Hi, @halfcrazy thank you for reporting this. You are right. Add and Remove methods look inconsistent. The consistent package has many established users. I think it's good to keep this inconsistency for the sake of backward compatibility.