search

buremba / django-admin-tools

Yet another django admin tools fork
MIT License
1 stars 0 forks source link

What are your plans for this fork? #1

Open andybak opened 9 years ago

andybak commented 9 years ago

I'm just wondering whether to invest more time in django-admin-tools and your fork has the some recent activity. I'm wondering what changes you made and what you had in mind.

From my side - I'm keen on updating the css to match the new flat admin planned for Django 1.9. The current gradients look a touch dated in comparison.

buremba commented 9 years ago

Sorry for the messy commits. I fixed some of the bugs, added a few features like searching and custom menubar. Combined with the other Django module called django-simit (https://github.com/buremba/django-simit) the aim was to develop an admin web interface that can be used as a CMS. The UI also changed significantly, I tried to modernize the default theme but it still needs some work since I'm not actually a web designer. You may try to install and test the module but here is a few screenshots to show you how it looks like: screen shot 2015-06-21 at 00 15 47 screen shot 2015-06-21 at 00 16 14 screen shot 2015-06-21 at 02 17 00

Unfortunately I'm not actively working on this project for a while so it doesn't support Django 1.8 yet (Actually I didn't even try to install on 1.8). However, if you want to work on this project, I would gladly help you.

andybak commented 9 years ago

Hi. That looks really nice!

  1. Are your changes here useful without django-simit?
  2. Are they backwards compatible?

We've moved the main repo to Github: https://github.com/django-admin-tools/django-admin-tools with izi's blessing so it looks like we might revitalize development somewhat. I'd be interested to know what improvements you've made that could be contributed back to the main project.

buremba commented 9 years ago

Hey,

  1. Yes, it's not required to install django-simit in order to use this module.
  2. I'm not really sure about that but I skimmed through the changes I made and it seems that it should be.

It might take some time for me to send a pull request to the main repository since I'm working on another project right now but I think the search feature might be useful.

It was actually an experiment so I should work on this feature for some more time and write unit tests but if you're willing to add it to the django-admin-tools, I can prepare a pull request and send it to the main repository when it's done.

andybak commented 9 years ago

Sounds great. Thanks.

The ideal thing for us would be to send separate pull requests for each feature - assuming there's other tweaks as well as the search. If it's just the search then that's find.

In general - the smaller the pull request the quicker it will get approved.

If it's any amount of work to do this then maybe create an issue to explain your new feature before you spend any time on cleaning it up for a pull request.