Taps section of the sidebar doesn't animate

[buresdv]

Bug Report

Mandatory Information

Describe the bug When adding or removing taps, the addition/removal animation doesn't play in the Taps section of the sidebar

To Reproduce Add or remove a tap. There will be no animation.

Expected Behavior The animation doesn't play

Screenshots https://github-production-user-asset-6210df.s3.amazonaws.com/22037369/272531402-0d5b1ffe-59dc-4379-8f8d-bdaf345cd075.mov

System and Cork Information:

• macOS version: 14
• Cork Version: 1.3
• Did you compile Cork yourself?: Yes

Optional Information

Additional context N/A

Checklist

• [x] I filled everything out under Mandatory Information
• [x] This bug affects the UI and I have included a screenshot

[boscojwho]

@buresdv Is the animation logic in a private branch? Also animation works for Installed Formulae and Installed Casks, right?

[buresdv]

@boscojwho the entire code is here. You can find the animation logic here: https://github.com/buresdv/Cork/blob/2fc2f3a0ad65cfc2311e8f9bfe23f1ce60bb3fd0/Cork/Views/Taps/Add%20Tap%20View.swift#L146

And yes, the animation works fine for Installed Formulae and Installed Casks. Thank you for looking into it!

[boscojwho]

Took a quick look at repro:

• Seems like "Add" does animate, but it appears to animate the wrong tap (see video).
• "Remove" tap indeed doesn't animate when triggered using right-click in sidebar view.

https://github.com/buresdv/Cork/assets/2549615/acaf1d46-d3b6-49a7-a262-b7ca23c9939a

[boscojwho]

"Remove" tap animates with the same buggy behaviour as "Add" if triggered using button in Detail view (see end of video below):

https://github.com/buresdv/Cork/assets/2549615/a7cae938-c62f-40b2-a754-a5e4d6ec7318

[boscojwho]

func removeTap(name: String, availableTaps: AvailableTaps, appState: AppState, shouldApplyUninstallSpinnerToRelevantItemInSidebar: Bool = false)

• When shouldApplyUninstallSpinnerToRelevantItemInSidebar = true, animation fails.
• When shouldApplyUninstallSpinnerToRelevantItemInSidebar = false, remove animates out the wrong tap.

[boscojwho]

Seems like remove formulae also doesn't animate at all:

• Item being removed moves to a new index with spinner, then disappears without animation.

https://github.com/buresdv/Cork/assets/2549615/94523b72-2920-4eb3-bda3-627071315222

[boscojwho]

Update: Added repo that reproduces behaviour (https://github.com/boscojwho/sidebar-list-add-remove-row-mac)

Interesting, I made a test macOS project to see whether it's system behaviour/bug, and I was able to repro the behaviour here: https://gist.github.com/boscojwho/6bdf2df26750602262d23754ea90bcaa

• In that gist, the List (sidebar view) animates add/remove row actions correctly if it ISN'T in a navigation split view sidebar, but exhibits the same buggy animation behaviour when inside a navigation sidebar.
• Not sure if system bug (I rarely write actual Mac apps, lol) or app bug (I used the same basic logic as in Cork).

[buresdv]

Thanks a lot for the writeup

"Remove" tap animates with the same buggy behaviour as "Add" if triggered using button in Detail view (see end of video below):

Did you try this on main? This was a bug in 2fc2f3a0ad65cfc2311e8f9bfe23f1ce60bb3fd0 and I think I fixed it on main.

Update: Added repo that reproduces behaviour (https://github.com/boscojwho/sidebar-list-add-remove-row-mac)

I can reproduce on Somona 14.0, as well as Ventura.

Not sure if system bug (I rarely write actual Mac apps, lol) or app bug (I used the same basic logic as in Cork).

I wouldn't be surprised if it was a system bug, macOS is an afterthought for the SwiftUI team 😭 If you could change the logic, what would you change?

[boscojwho]

• I synced my fork with main branch yesterday (it's 4 commits behind today, but I don't see any changes related to this bug).
• I reproduced this on Sonoma (not on that Mac right now, so not sure which build).
• macOS an afterthought?! Unpossible! Not sure, but I'll probably take another look at the sample project and see if it's fixable there. If we can't fix it there, then it's a bug report to Apple (i.e. no point trying to fix it in Cork).

[boscojwho]

@buresdv So, if we use a ScrollView + LazyVStack setup in the sidebar, row insert/removal animations work properly (see video):

• But the rows (NavigationLink) look different out-of-the-box.
• So we'll have to do some extra work to make them look the way they do now.

https://github.com/buresdv/Cork/assets/2549615/b9040f9c-86b0-47d7-acec-3bcbf47d6f64

[buresdv]

@boscojwho Okay, that ScrollView solution looks great in regards to the animations. Like you said, it just needs some extra styling

[boscojwho]

Yea, I can take a look and also switch out the current setup with this new one if you want.

[buresdv]

Yea, I can take a look and also switch out the current setup with this new one if you want.

That'd be great if you could give it a go, just make sure the searching still works properly and that the sections can be collapsed. Thank you!

[boscojwho]

• [x] Replace sidebar view setup with ScrollView + LazyStack
• [x] Change NavigationLink row styling so it looks like before.
• [ ] Ensure sidebar search works like before.
• [x] Ensure sections are collapsible like before.

[boscojwho]

I'm trying to figure out if .searchable works with a ScrollView+LazyVStack in split view sidebar on macOS (would really suck if it doesn't). Other than that, I got the setup to behave and look like a sidebar List.

https://github.com/buresdv/Cork/assets/2549615/0536abfc-b14a-40ba-9499-d4fa90f2dfcf

[boscojwho]

Unfortunate, looks like .searchable() doesn't play well with non-List views on macOS (the same setup works on iPhone and iPad with .sidebar placement):

• We'd have to add a custom TextField for search, but that would mean losing all the built-in search token functionality that comes with .searchable().
• Or see if there's a way to keep List and fix this animation bug (did quickly try using List with LazyVStack setup...the animation bug looks even worse XD)

https://github.com/buresdv/Cork/assets/2549615/220dfdc9-19c4-4fe1-a76a-381e2e9bdac5

[buresdv]

I wish Apple paid SwiftUI on the Mac 30% of the attention it gets on iPlatforms

[buresdv]

Moved to "Waiting for Apple to Fix" since there doesn't seem to be anything we can do

[SilverMarcs]

.listStyle(.inset) with .scrollContentBackground(.hidden) should render animations correctly. And you can retain all the built-in functionality of List.

Of course this is far from perfect since it probably requires other tweaks to get list sections and to separators to show in the desired manner,