buresdv / Cork

A fast GUI for Homebrew written in SwiftUI
https://corkmac.app
2.33k stars 131 forks source link

ci: Add .swiftlint.yml #386

Closed cclauss closed 3 months ago

cclauss commented 3 months ago

Related to:

Requested at https://github.com/buresdv/Cork/pull/378#issuecomment-2295405160

https://github.com/realm/SwiftLint?tab=readme-ov-file#configuration

% swiftlint --fix can automatically fix:

buresdv commented 3 months ago

Thanks, I already have a swiftlint config in another branch, see here: https://github.com/buresdv/Cork/blob/main.swiftlint/.swiftlint.yml

Could you please use that one instead? The code in branch main.swiftlint is already fixed for this config, and this config will be used in the future

cclauss commented 3 months ago

Cool! You are way ahead of me. Closing.

Once https://github.com/buresdv/Cork/blob/main.ci/.github/workflows/swift.yml and https://github.com/buresdv/Cork/blob/main.swiftlint/.swiftlint.yml on the same branch things will be easier to work with.

buresdv commented 3 months ago

WE were thinking of the same thing with Swiftlint 😂

buresdv commented 3 months ago

@cclauss By the way, do you have any other experience with GitHub CI and releasing macOS apps? I've been trying to create a CI/CD pipeline for automatically compiling and stapling new versions, but I could never get it working. It's on the branch ci (not to be confused with main.ci)

cclauss commented 2 months ago

I have tons of experience with GitHub CI and I used to release macOS apps in the olden days. I will look into it tomorrow.

buresdv commented 2 months ago

Thanks a lot, I'd really appreciate it!