Closed burghout closed 6 years ago
@Trateotu I try to run the tests but the integrationTest fails at reading the network. Same for you?
@burghout Everything still passes for me, maybe a cross platform thing?
@burghout did you get any output on what check failed?
@Trateotu yes it was the backward slashes in the path for the expected outputs, fixed it
maybe good to see if it still works for you, could you quickly check?
yes still works!
@Trateotu have a look at the integration test -> test busroutes, i think this works ok? will have to test with a DRT test case but maybe better to merge this and then make a new branch off your latest code?
BTW the test for comparing results fails now because we add extra transit lines.
Great thanks! Sounds like a good idea, and I'll check it out and see how things run on my end, maybe with a DRT case already. Can then merge into David-DRT and pull changes into David-PassengerDecisions from there. Might work on adding the auto-created lines to the CSGM directly off of PassengerDecisions since this is kindof within that scope. Otherwise can branch off of David-DRT
@burghout ok I ran into a couple of errors, added a fix in eaafb58d3a25b203612603187b543ba7fe2badfc. If it looks ok and like I didnt break anything then I can merge.
Think there may be some fiddling of whatever dependencies there are on e.g. the Network::busroutes and Network::buslines vectors, and depending on how we define Origin and Destination nodes for stops, but this should work!
@Trateotu Thanks for all the fixes, go ahead and merge!
[x] Create partial busroute from stop to stop
[x] Add path from Origin to OriginStop and from DestinationStop to Destination to busroute
[x] Create the BusLine with the new Busroute