burghout / mezzo

Mezzo mesoscopic traffic simulation
2 stars 0 forks source link

Add dynamic creation of busroutes and buslines #50

Closed burghout closed 6 years ago

burghout commented 6 years ago
burghout commented 6 years ago

@Trateotu I try to run the tests but the integrationTest fails at reading the network. Same for you?

Trateotu commented 6 years ago

@burghout Everything still passes for me, maybe a cross platform thing?

Trateotu commented 6 years ago

@burghout did you get any output on what check failed?

burghout commented 6 years ago

@Trateotu yes it was the backward slashes in the path for the expected outputs, fixed it

burghout commented 6 years ago

maybe good to see if it still works for you, could you quickly check?

Trateotu commented 6 years ago

yes still works!

burghout commented 6 years ago

@Trateotu have a look at the integration test -> test busroutes, i think this works ok? will have to test with a DRT test case but maybe better to merge this and then make a new branch off your latest code?

burghout commented 6 years ago

BTW the test for comparing results fails now because we add extra transit lines.

Trateotu commented 6 years ago

Great thanks! Sounds like a good idea, and I'll check it out and see how things run on my end, maybe with a DRT case already. Can then merge into David-DRT and pull changes into David-PassengerDecisions from there. Might work on adding the auto-created lines to the CSGM directly off of PassengerDecisions since this is kindof within that scope. Otherwise can branch off of David-DRT

Trateotu commented 6 years ago

@burghout ok I ran into a couple of errors, added a fix in eaafb58d3a25b203612603187b543ba7fe2badfc. If it looks ok and like I didnt break anything then I can merge.

Think there may be some fiddling of whatever dependencies there are on e.g. the Network::busroutes and Network::buslines vectors, and depending on how we define Origin and Destination nodes for stops, but this should work!

burghout commented 6 years ago

@Trateotu Thanks for all the fixes, go ahead and merge!