issue when applyng filter

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.

MIT License

4.17k stars 991 forks source link

issue when applyng filter #221

Closed romaan-khan closed 4 years ago

romaan-khan commented 4 years ago

When applying filter to portrait image ... it takes black borders automatically to left and right of image and adds those unwanted border in the filtered image. please help

romaan-khan commented 4 years ago

filter

jayansonjay commented 4 years ago

I have the same problem, @romaankhanAndroid have you resolved this?

romaan-khan commented 4 years ago

I have the same problem, @romaankhanAndroid have you resolved this? Just take that image view to wrap content and set ajustViewBounds to true it will work fine

KucherenkoIhor commented 4 years ago

@romaankhanAndroid could you please explain how to fix it?

KucherenkoIhor commented 4 years ago

Hey @burhanrashid52 . Do you know how to fix this?

vasanihardik commented 4 years ago

any one resolved this issue if yes share your ans with us thank you!

romaan-khan commented 4 years ago

@romaankhanAndroid could you please explain how to fix it?

Just take that image view to wrap content and set ajustViewBounds to true it will work fine

burhanrashid52 commented 4 years ago

Please close the issue if it gets resolved.

vasanihardik commented 4 years ago

which file in changed this two line already in there but still same issue

still not resolved this issue.

On Tue, Sep 15, 2020 at 3:41 PM Burhanuddin Rashid notifications@github.com wrote:

Please close the issue if it gets resolved.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/burhanrashid52/PhotoEditor/issues/221#issuecomment-692617632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHYLQ7VEF3FQPLXVAQLIXDSF44WJANCNFSM4KJN5R5Q .

vasanihardik commented 4 years ago

this issue not resolved @burhanrashid52

AkashKrx commented 3 years ago

Just take that image view to wrap content and set ajustViewBounds to true it will work fine

I have the following code in place and I a still getting black bars around my image. @romaankhanAndroid

public void setFilterEffect(PhotoFilter filterType) {
        LayoutParams layoutParams = parentView.getSource().getLayoutParams();
        layoutParams.width = LayoutParams.WRAP_CONTENT;
        layoutParams.height = LayoutParams.WRAP_CONTENT;
        parentView.getSource().setLayoutParams(layoutParams);
        parentView.getSource().setAdjustViewBounds(true);
        parentView.setFilterEffect(filterType);
    }

yy1023283126 commented 3 years ago

anyone can improve this？

NahlaSaadAlDeen commented 2 years ago

any one get solution for this issue?