search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.16k stars 992 forks source link

Refactoring #352

Closed burhanrashid52 closed 3 years ago

burhanrashid52 commented 3 years ago

@lucianocheng @tanoDxyz Can you please review it.

tanoDxyz commented 3 years ago

@lucianocheng @tanoDxyz Can you please review it.

sure

lucianocheng commented 3 years ago

Will look this weekend!

burhanrashid52 commented 3 years ago

Took a look. Overall looks good.

I do think we should stop and consider how the helpers and abstract classes should work re: Graphic et al. If we want to add functionality in the future, or begin to expose more things to the user, we should be clear where it should go.

First of all, thanks for the review. I've replied to comments. You can resolve the conversation as per the answer. Happy to continue the discussion on other points.