burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.

MIT License

4.13k stars 991 forks source link

Kotlin Migration #360

Closed burhanrashid52 closed 2 years ago

burhanrashid52 commented 3 years ago

This issue is created to see demand for Koltin for this library. Please provide your feedback in the comments or you can upvote and downvote the issue.

lucianocheng commented 3 years ago

Speaking strictly for myself, this project not being in Kotlin diminishes my ability to contribute.

It is literally my only remaining Android Java project.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

anderbytes commented 3 years ago

Brace yourselves, I'm working on this. The first commit will be ONLY about converting each JAVA to KOTLIN, right after I'll be working on a commit with the only purpose of replacing the goddamn ASYNC with Coroutines

anderbytes commented 3 years ago

All seems to work but I'm having some trouble with the FILE PROVIDER and permissions to save on storage. Don't know why, I can't find the error, I'm missing something and I don't know what it is.

I'll be doing a commit right now, someone please go there and take a look and help me fix it. Thanks!

ps: "photoeditor" library inside the project is working. The permission problem mentioned above is in the photoeditor app of this repository, that implements the library.

lucianocheng commented 3 years ago

I'll be doing a commit right now, someone please go there and take a look and help me fix it. Thanks!

@anderbytes can you link your branch? Trying to do this on my end as well. I'm going to hold off major contributions until this migration happens.

anderbytes commented 3 years ago

Here it goes @lucianocheng

https://github.com/anderbytes/PhotoEditor

lucianocheng commented 3 years ago

All seems to work but I'm having some trouble with the FILE PROVIDER and permissions to save on storage. Don't know why, I can't find the error, I'm missing something and I don't know what it is.

What model / Android version are you running where you see this?

It may be a good idea to not convert the whole project to kotlin at once. Maybe just the app first? Or even just the tests would be a huge improvement but a good foray into a larger change.

anderbytes commented 3 years ago

I'm doing all my tests on a Moto E5 and a Samsung M31, probably the issue was seen on both, I'd have to look into it again

Everything seems to work... but this. So maybe the full migration to Kotlin is actually possible.

anderbytes commented 2 years ago

418 did a pull request on the app conversion to Kotlin

@lucianocheng @burhanrashid52

anderbytes commented 2 years ago

All seems to work but I'm having some trouble with the FILE PROVIDER and permissions to save on storage. Don't know why, I can't find the error, I'm missing something and I don't know what it is.

What model / Android version are you running where you see this?

It may be a good idea to not convert the whole project to kotlin at once. Maybe just the app first? Or even just the tests would be a huge improvement but a good foray into a larger change.

Just to point that in the recent Kotlin conversion I had stumbled again with that, but know with more knowledge of Kotlin I was able to solve the issue