search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.13k stars 991 forks source link

text editor #369

Closed rtz333 closed 3 years ago

rtz333 commented 3 years ago

My first time pr. sorry if there's something wrong

burhanrashid52 commented 3 years ago

I am not able to review the changes. I see only two files with change. You need fork the latest from this project. Commit the changes and then create a PR. This video might help. https://www.youtube.com/watch?v=rgbCcBNZcdQ

rtz333 commented 3 years ago

@burhanrashid52 I have some updated .hope it helps you

burhanrashid52 commented 3 years ago

Can you please add test and screenshot. Check TextStyleBuilderTest for reference.

rtz333 commented 3 years ago

imgtest screenshot

burhanrashid52 commented 3 years ago

This look great. However one test is failing. This test is failing because of entries in map count. Let me know once you push the fix.

rtz333 commented 3 years ago

@burhanrashid52 can u test again. i still dont know how to test it @@@

burhanrashid52 commented 3 years ago

The test are failing again. Please run the unit test in local using ./gradlew tests

rtz333 commented 3 years ago

The test are failing again. Please run the unit test in local using ./gradlew tests

i think it work now.can you check it again