search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.13k stars 991 forks source link

PE-379 Set proper layout to ImageView and DrawingView #380

Closed stephanepechard closed 3 years ago

stephanepechard commented 3 years ago

in order not to draw outside of the source image. Here is the result with the same type of drawing as in the issue.

Screenshot_1626710746

Resolves #379

burhanrashid52 commented 3 years ago

Thanks for the PR. There is an issue with CI. I am looking into it.

stephanepechard commented 3 years ago

As requested, I added a method to PhotoEditor.Builder to be able to switch this off, which is the default configuration, so current use should not be broken. I had to refactor a bit the PhotoEditorView init() method to ease the appliance of the new LayoutParams.

burhanrashid52 commented 3 years ago

@stephanepechard Is it possible for you to create the PR for wiki documentation as well ?

burhanrashid52 commented 3 years ago

It is possible for you update the wiki and create a PR ? https://github.com/burhanrashid52/PhotoEditor.wiki.git

stephanepechard commented 3 years ago

Will do it, I just do not have much time at the moment, I'm in holidays :-)

stephanepechard commented 3 years ago

It is possible for you update the wiki and create a PR ? https://github.com/burhanrashid52/PhotoEditor.wiki.git

I cannot fork this repo. How can I create a PR for this?

burhanrashid52 commented 3 years ago

Yeah, we cannot do that. Never mind I will update the wiki. Enjoy your holidays!!! :)

stephanepechard commented 3 years ago

Thanks!