burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.13k stars 991 forks source link

When I saveFilter,blinking a black sreen #382

Closed yy1023283126 closed 2 years ago

yy1023283126 commented 3 years ago

There is a mask in the demo so it is not obvious

burhanrashid52 commented 3 years ago

Sorry I did not understand. Can you please use the issue template?

anderbytes commented 3 years ago

Just to add a little to the discussion: It never bothered me enough, but when I save the image, for just some milliseconds the editor blinks black, then comes back normally with the content. It's so quick I found it "ok" to handle.

Don't know if that's related to what you said here.

yy1023283126 commented 3 years ago

Just to add a little to the discussion: It never bothered me enough, but when I save the image, for just some milliseconds the editor blinks black, then comes back normally with the content. It's so quick I found it "ok" to handle.

Don't know if that's related to what you said here.

Yes,that‘s it

yy1023283126 commented 3 years ago

Just to add a little to the discussion: It never bothered me enough, but when I save the image, for just some milliseconds the editor blinks black, then comes back normally with the content. It's so quick I found it "ok" to handle.

Don't know if that's related to what you said here.

Do you know how to handle it?

anderbytes commented 3 years ago

When I meant Handle I was talking about living with it

anderbytes commented 3 years ago

Right now I'm focused on getting #381 done because it's very important here, when my head is clear on that, I'll take a look at your issue.

yy1023283126 commented 3 years ago

Right now I'm focused on getting #381 done because it's very important here, when my head is clear on that, I'll take a look at your issue.

Thank you,my friend

anderbytes commented 3 years ago

Had some time to look into it... but nothing so far... but it seems something in the internals of the VIEW rendering into the CANVAS, both native from the Java libraries.

Unfortunately the blinking doesn't appear at the correct time if we are debugging, only after we release the debug from pause and the view drawing again.

I would guess we need some expert who knows a lot about GL + graphic rendering on Android.

yy1023283126 commented 3 years ago

Had some time to look into it... but nothing so far... but it seems something in the internals of the VIEW rendering into the CANVAS, both native from the Java libraries.

Unfortunately the blinking doesn't appear at the correct time if we are debugging, only after we release the debug from pause and the view drawing again.

I would guess we need some expert who knows a lot about GL + graphic rendering on Android.

Yes,that‘s very difficult’

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

anderbytes commented 2 years ago

Don't close it

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.