burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.13k stars 991 forks source link

Using painting In PhotoEditorView , drawing mode is working on "ImageView" and "RelativeLayout" both instead of only "ImageView" #385

Closed wasim15185 closed 2 years ago

wasim15185 commented 3 years ago

Problems Preview (watch PaintFragment)

Updated preview Link

Problems :

  1. In PaintFragment Although ja.burhanrashid52.photoeditor.PhotoEditorView width is android:layout_width="match_parent" but it is not stretch width as parent width
  2. We know PhotoEditorView is combination of ImageView and RelativeLayout , So ja.burhanrashid52.photoeditor.PhotoEditorView width is not as parent then when Draw upon on ImageView then it's ok but when draw outside of ImageView means RelativeLayout then Drawing is Also working

PhotoEditorView in PaintFragment

  `<ja.burhanrashid52.photoeditor.PhotoEditorView
        android:id="@+id/paint_view"
        ImgTransitionName="@{@string/img_transition_unique_name}"
        android:layout_width="match_parent"
        android:layout_height="450dp"
        android:layout_marginTop="8dp"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        tools:photo_src="@drawable/suv" />`
burhanrashid52 commented 3 years ago

I think #379 might solve this issue. You can also check #380. Its in version 1.5.1

wasim15185 commented 3 years ago

Thank You 👍

wasim15185 commented 3 years ago

@burhanrashid52 but same problem with adding Sticker and Text (Edited Comment)

burhanrashid52 commented 3 years ago

@burhanrashid52 but same problem with adding Sticker and Text (Edited Comment)

@stephanepechard Can we fix this ?

stephanepechard commented 3 years ago

@wasim15185 I'm not sure to understand the problem. Is it that Stickers and Texts appears outside the source image?

wasim15185 commented 3 years ago

@stephanepechard I am giving the sticker preview and after some time i will give the text preview because text fragment have some bug and i am redesigning from scratch ...

preview 1 text

preview 2 text

wasim15185 commented 3 years ago

@burhanrashid52 please resolve the issue

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.