search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.13k stars 991 forks source link

Improve behavior in the tap and drag event #390

Closed jsericksk closed 2 years ago

jsericksk commented 3 years ago

As I mentioned in the previous issue, the editing behavior in onLongClick() didn't look very good. But switching to onClick() didn't seem like a good idea due to the library's current behavior. Looking at the code a bit, I realized that the drag event can only be done if the sticker is in focus. By removing this condition and combining it with my previous onClick() suggestion, the behavior is much better, in my opinion.

Current behavior: gif-1 Expected behavior: gif-2

What do you think?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.