burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.12k stars 989 forks source link

Disable Compression #411

Closed EbelloImbox closed 2 years ago

EbelloImbox commented 2 years ago

Hello I am looking for a way to disable compression, is it possible?

I am doing compression for my own with other library and I would like to use it because I am doing a double compression right now, with PhotoEditor and later with my own library.

Regards.

EbelloImbox commented 2 years ago

I am watching PhotoEditor code and this could be a problem too:

private Bitmap captureView(View view) {
        Bitmap bitmap = Bitmap.createBitmap(
                view.getWidth(),
                view.getHeight(),
                Bitmap.Config.ARGB_8888
        );
        Canvas canvas = new Canvas(bitmap);
        view.draw(canvas);
        return bitmap;
    }

This is the way to build the final image and it could be a problem because bitmap resolution is the resolution of the view, and view is a PhotoEditorView, so if an user has a low resolution mobile, bitmap will be a low resolution image.

Any help to get a hight quality image from editor?

burhanrashid52 commented 2 years ago

Yes, you are right. This library is not designed to handle scaling. This issue is discussed here #10

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.