Closed anderbytes closed 2 years ago
@burhanrashid52 @lucianocheng Hope I didn't do anything wrong, I'm no expert at VCS
Attention @burhanrashid52 and @lucianocheng
I tried doing some tests here and at the moment of the share, the FileURI created can't be reached. Probably I did something wrong with the FileProvider conversion, and I'm having trouble troubleshooting the cause.
Any of you can take a look?
@anderbytes I'm happy to review code that works, but going back and forth on a single review is not a recipe for success.
If you are not confident that this PR is in good working order, I would propose we go back to my original suggestion and submit smaller PRs with smaller changes.
Either way let's wait for @burhanrashid52 to figure out what's going on with GitHub actions not running first.
I'll now use my little free time to focus on my personal projects. Good luck for you guys. Hope you find someone better at testing.
New PR requested by maintainer, hope I got it right