search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.12k stars 989 forks source link

PE-422: Convert PhotoApp to Kotlin #423

Closed lucianocheng closed 2 years ago

lucianocheng commented 2 years ago

Convert PhotoApp to Kotlin per prior discussion on PE-360

@burhanrashid52 let me know if you have time to review this. If not I'll have someone from my team review it.

burhanrashid52 commented 2 years ago

@lucianocheng Thanks for the PR. I will be more than happy if someone from your team can review this.

lucianocheng commented 2 years ago

@lucianocheng Thanks for the PR. I will be more than happy if someone from your team can review this.

@burhanrashid52 Sounds good. Could you add @tiendung717 as a collaborator? I will have him review it. Thanks.

lucianocheng commented 2 years ago

@burhanrashid52 I think this PR is ready to merge into kotlin-conversion. OK to do so?

burhanrashid52 commented 2 years ago

@lucianocheng Thanks. I am currently looking into the github action issue. Let me try to run the CI for this. Will merge it if it takes more time.

burhanrashid52 commented 2 years ago

@lucianocheng Can you please the take latest from kotlin-conversion and push the changes in this branch?

lucianocheng commented 2 years ago

@lucianocheng Can you please the take latest from kotlin-conversion and push the changes in this branch?

@burhanrashid52 done. Looks like tests are running.