Closed psuzn closed 2 years ago
Sure, It is similar to the line but has an arrow at the end. https://user-images.githubusercontent.com/19205305/149757952-fe36a204-b1ef-4e71-90f8-378d1e5a8e9b.mp4
@psuzn Thanks. Currently, we are converting the library into Kotlin #428 So we might need to redo these changes again in Kotlin. So I suggest waiting for the conversation to be completed and once it's merged, you can rebase with the new Kotlin code and make a PR with those changes. Sounds Good ?
@burhanrashid52, I've updated this. Please have a look when you get some time.
@psuzn The code looks good to me. However, I've two things.
@burhanrashid52, I had added a test for the enums beside that I don’t think there is a shape-specific test setup to verify the shape being drawn, is there?
The LineBuilder
sounds like a good idea, but I've been super busy lately and not sure I would be able to add this.
@psuzn No worries. You can contribute back whenever you are available. Till then I will keep this PR open as a reference for others.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR was closed because it has been stalled for 5 days with no activity.
@psuzn Thanks for the PR. Can you please add a gif or screenshot on how this arrow looks/works ?