Using DataBinding in Sample app

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.

MIT License

4.12k stars 989 forks source link

Using DataBinding in Sample app #435

Closed burhanrashid52 closed 1 year ago

burhanrashid52 commented 2 years ago

[ ] ~~Use data binding to bind views in the sample app.~~
[x] Remove necessary null values.
[x] Use lateinit.

wasky commented 1 year ago

Second and third tasks from the list for 'EditImageActivity' are resolved in #494

wasky commented 1 year ago

My personal opinion is that sample app should not use data binding / view binding:

Sample should be as simple as possible, easy to understand also for those who are not using data binding / view binding.
Data binding increases build time (probably not a big issue because the project is rather small).
There's Jetpack Compose on the horizon, so probably in the future it will be better to migrate sample app to Compose rather than integrate data binding / view binding.

burhanrashid52 commented 1 year ago

My personal opinion is that sample app should not use data binding / view binding:

* Sample should be as simple as possible, easy to understand also for those who are not using data binding / view binding.

* Data binding increases build time (probably not a big issue because the project is rather small).

* There's Jetpack Compose on the horizon, so probably in the future it will be better to migrate sample app to Compose rather than integrate data binding / view binding.

Make sense. Closing the issue.