search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.14k stars 991 forks source link

Fix the opacity #467

Closed yoshida0261 closed 2 years ago

yoshida0261 commented 2 years ago

https://github.com/burhanrashid52/PhotoEditor/issues/427#issuecomment-1003568281

As pointed out above, the order has been changed.

gabrielnakhata commented 1 year ago

Thanks, I'll compare... but in my project I only import the library, I don't import the complete project, in my case I use: -> implementation: ''com.burhanrashid52:photoeditor:2.0.0'' and use the folders:

-> base{baseActivity & baseFragment}, -> tools {EditingToolsAdapter & ToolsType} -> PhotoEditor with the folders I mentioned above, I also have the classes I use:

ColorPickerAdapter, EditImageActivity, FileSaveHelper, PorpertiesBSFragment, ShapeBSFragment & TextEditorDialogFragment....

In this case, I see that as I only use lib which will obviously make me take advantage of the classes that are in the repository, knowing that I already verified that the supposed correction mentioned above, the merge was not done, however I cloned the repository and made the aforementioned modification and it did not work of OPACITY.

Thanks for your help and patience, I think that for me to get the solution I'll need to adjust the root of the photoeditor git repository, if I'm wrong don't exist if you can help...

Thank you, Gabriel Nakhata.

gabrielnakhata commented 1 year ago

It worked, but the modification was not merged. It needs to be merged. I made the modification and tried to upload the branch and request a pull request, but I don't have authorization, I can do it if I find it simpler .... @burhanrashid52

gabrielnakhata commented 1 year ago

image

burhanrashid52 commented 1 year ago

It worked, but the modification was not merged. It needs to be merged. I made the modification and tried to upload the branch and request a pull request, but I don't have authorization, I can do it if I find it simpler .... @burhanrashid52

I don't see the PR. Can you please raise the PR to this repo?

gabrielnakhata commented 1 year ago

Oops, sorry I've been going a mile a minute, and I forgot to check the rules for making collaborations, so I forked, created a branch with the issue's name, made the adjustment and requested the pull request. @burhanrashid52