search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.14k stars 991 forks source link

Photo Editor state is lost on configuration change #473

Closed mbilal51214 closed 1 year ago

mbilal51214 commented 2 years ago

Is your feature request related to a problem? Please describe. Problem is when theme is changed like from dark mode to light mode or vice versa. The photoEditorView state is lost, I am using MVVM architecture but there is no way to save the state of photoEditor like there is no way I can save the drawn paths on the view so that I can save in my viewModel and pass to the initializer again after configuration change.

Describe the solution you'd like If in the onPhotoEditorListener I get the drawn paths, and then if there is a mechanism to pass these paths again in the builder, So the states will be maintained, because the lost views will be drawn again.

Describe alternatives you've considered I am thinking to rewrite the whole library, or to search another library that provide this kind of solution.

Additional context Add any other context or screenshots about the feature request here.

burhanrashid52 commented 2 years ago

Seems like the duplicate of #41 Check my comment.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 5 days with no activity.