search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.08k stars 983 forks source link

The Opacity doesn't work in the demo #493

Closed gabrielnakhata closed 1 year ago

gabrielnakhata commented 1 year ago

I report a problem in the functionality of setting the opacity of the specific seekBar for this one.

I believe the problem is in the function: Class: ShapeBSFragment in the onProgressChanged function

burhanrashid52 commented 1 year ago

I report a problem in the functionality of setting the opacity of the specific seekBar for this one.

I believe the problem is in the function: Class: ShapeBSFragment in the onProgressChanged function

do you have a fix for this?

gabrielnakhata commented 1 year ago

Good afternoon, I'm actually debugging and I still haven't found a solution, I'm investigating but with some hope that you can help me, I compared the java code that works perfectly to understand at what point it doesn't work, I saw that there is an obsolete function for setOpacity( ), THEN it is recommended to use SetShape()..

image

image

burhanrashid52 commented 1 year ago

@gabrielnakhata Did you try #467 and this ?

gabrielnakhata commented 1 year ago

It worked, but the modification was not merged. It needs to be merged. I made the modification and tried to upload the branch and request a pull request, but I don't have authorization, I can do it if I find it simpler .... @burhanrashid52

-> The adjustment was made only in java in the Kotlin version Migration was not made, authorize me to send the adjustment to the pull request