search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.08k stars 983 forks source link

Test for opacity functionality #496

Closed burhanrashid52 closed 1 year ago

burhanrashid52 commented 1 year ago

Issue context and description

burhanrashid52 commented 1 year ago

@wasky I am not able to assign this task to you. Can you look into it?

wasky commented 1 year ago

I'm waiting for #497 with this to avoid conflicts.

wasky commented 1 year ago

After I made changes in dependencies needed for this task I have a following issue:

The number of method references in a .dex file cannot exceed 64K

There are few possibilities to solve the problem but the simplest is to update minSdkVersion to 21 (Android 5.0). I checked that all apps from the README have minSdkVersion at least 21. Also according to stats Android 5.0+ is installed on 98.8% devices. So maybe we could update minSdkVersion to 21 in the lib?

burhanrashid52 commented 1 year ago

After I made changes in dependencies needed for this task I have a following issue:

The number of method references in a .dex file cannot exceed 64K

There are few possibilities to solve the problem but the simplest is to update minSdkVersion to 21 (Android 5.0). I checked that all apps from the README have minSdkVersion at least 21. Also according to stats Android 5.0+ is installed on 98.8% devices. So maybe we could update minSdkVersion to 21 in the lib?

I am in for 21. Just need to update in docs.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 5 days with no activity.