Update Gradle & Android Gradle Plugin - Githubissues

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.

MIT License

4.08k stars 983 forks source link

Update Gradle & Android Gradle Plugin #497

Closed wasky closed 1 year ago

wasky commented 1 year ago

Update Gradle & Android Gradle Plugin
Fix Lint errors from new Lint rules
Update gradle files by ./gradlew wrapper command
Updates made by Upgrade Assistant in Android Studio

wasky commented 1 year ago

@burhanrashid52 Build failed because new version of Android Gradle Plugin requires Java 11. Are you able to update Java?

burhanrashid52 commented 1 year ago

@burhanrashid52 Build failed because new version of Android Gradle Plugin requires Java 11. Are you able to update Java?

No. I've not updated it to java 11. But I guess we can change it in CI here to make the build work again.

wasky commented 1 year ago

That's what I needed. Thanks for the clue! :)

burhanrashid52 commented 1 year ago

That's what I needed. Thanks for the clue! :)

Seems like the PR does not run with the latest config. Need to update the config in the master first and then updated this branch.

wasky commented 1 year ago

Seems like the PR does not run with the latest config. Need to update the config in the master first and then updated this branch.

There was a problem with old version of Roboelectric and I didn't update Java version for ui tests. Everything is OK now.

wasky commented 1 year ago

LGTM. Should we merge this before #492 ?

Yes