search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.14k stars 991 forks source link

Update README.md and CHANGELOG.md #503

Closed wasky closed 1 year ago

burhanrashid52 commented 1 year ago

@wasky We Need to update the saving example with the coroutine one. We also need to keep the old one as well.

wasky commented 1 year ago

We also need to keep the old one as well.

Is it related to #511 and you want to keep Java support?

burhanrashid52 commented 1 year ago

We also need to keep the old one as well.

Is it related to #511 and you want to keep Java support?

Yes. For documentation purposes.

wasky commented 1 year ago

I would introduce new API before the release rather than keep the old one in docs. The reason for this is the exception handling. In current old version of API and in AsyncTask version of API you can't handle potential exceptions from the lib. In new API this will work:

try {
    photoEditor.saveAsFile(...)
} catch(e: Exception) {
    //
}

I made a PR with new API for Java (#512) and changed the README in this PR to show example usage of new API for borh Java and Kotlin.

burhanrashid52 commented 1 year ago

@wasky I've published the jar. Can you update the documentation? Also, do you have a Twitter handle?