search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.07k stars 981 forks source link

Add test for correct alpha and color values #507

Closed wasky closed 1 year ago

wasky commented 1 year ago

This won't work until #505 is accepted.

wasky commented 1 year ago

@burhanrashid52 There's something wrong with CI build for this PR. It's running for over and hour now. Can you cancel the build manually?

burhanrashid52 commented 1 year ago

@burhanrashid52 There's something wrong with CI build for this PR. It's running for over and hour now. Can you cancel the build manually?

I am also not sure. Can you push something to re-run this ?

wasky commented 1 year ago

Everything's OK now, PR ready for review.

I split this PR into 4 commits for easier review. I suggest to review every commit separately.

burhanrashid52 commented 1 year ago

@wasky Since we have moved some test in androidTest, I am not sure if those test will run in the CI because the gradle test only run unit tests. Need to make changes in CI to run the test under androidTest as well.

burhanrashid52 commented 1 year ago

@wasky Since we have moved some test in androidTest, I am not sure if those test will run in the CI because the gradle test only run unit tests. Need to make changes in CI to run the test under androidTest as well.

Does ./gradlew check --stacktrace run all the test in photoEditor ? Can you confirm?

wasky commented 1 year ago

./gradlew test runs tests in test folder. ./gradlew connectedCheck runs tests in androidTest folder. Both tasks are executed by Github Actions. As a confirmation I created a new branch from this pull request in my forked repo and changed tests to fail. You can find the branch here and the results from tests here.