search

burhanrashid52 / PhotoEditor

A Photo Editor library with simple, easy support for image editing using paints,text,filters,emoji and Sticker like stories.
MIT License
4.07k stars 981 forks source link

Add saveAsFileBlocking() and saveAsBitmapBlocking() #512

Closed wasky closed 1 year ago

wasky commented 1 year ago

These can be called directly from Java.

burhanrashid52 commented 1 year ago

I would avoid giving responsibility to the client for handling saving images for java. Rather I will keep the old interface and introduce new suspend saveFileAsBlocking() APIs for coroutines.

wasky commented 1 year ago

I'm not sure if I understand correctly. There's already coroutine version: suspend saveAsFile(). No need for another suspending function. Do you want to remove deprecation warnings from old API and to cancel this PR?

burhanrashid52 commented 1 year ago

Do you want to remove deprecation warnings from old API and to cancel this PR?

Yes