mass_edit_view() should call get_form() on admin_obj

burke-software / django-mass-edit

Make bulk changes in the Django admin interface

152 stars 67 forks source link

mass_edit_view() should call get_form() on admin_obj #112

Closed PetrDlouhy closed 1 year ago

PetrDlouhy commented 1 year ago

@pedrovhb I just bumped into #103 issue myself. Thank you for that fix.

I just realized, that it is not enough - the get_form() function should be called also from admin_obj, otherwise it will pick up the wrong get_fieldsets() and run into problems later during rendering.

Similar applies also for get_queryset() fixed in #111

PetrDlouhy commented 1 year ago

@bufke @pedrovhb I will leave this PR open for few days, if you want to review it yourself. After that I will merge them.