search

burke-software / django-mass-edit

Make bulk changes in the Django admin interface
152 stars 67 forks source link

Updated README.md for Django 1.9+ #69

Closed namanshenoy closed 7 years ago

namanshenoy commented 7 years ago

Added code to get django-mass-edit working on Django 1.9+

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.231% when pulling c538e020c9c73d4dbb60f42e0a93c0ca66976314 on namanshenoy:master into 999a66cec0547edc5904e837efb11cc5e034c80a on burke-software:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.231% when pulling c538e020c9c73d4dbb60f42e0a93c0ca66976314 on namanshenoy:master into 999a66cec0547edc5904e837efb11cc5e034c80a on burke-software:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.231% when pulling 6eac412fcd402c368554d921ed8739e511f73c84 on namanshenoy:master into 999a66cec0547edc5904e837efb11cc5e034c80a on burke-software:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.231% when pulling 6eac412fcd402c368554d921ed8739e511f73c84 on namanshenoy:master into 999a66cec0547edc5904e837efb11cc5e034c80a on burke-software:master.

bufke commented 7 years ago

Why is this method better than? https://github.com/burke-software/django-mass-edit/blob/32e6dbe1255e6c2ed04bfbfc54d20467003ebdec/massadmin/__init__.py#L31

Does that init thing no longer work from a Django change?

namanshenoy commented 7 years ago

Yeah it didn't work when I tried. Might have something to do with template loaders.

bufke commented 7 years ago

I'd rather have the action just magically appear. Maybe try to figure out why it's not working for you and see if there is a alternative.

namanshenoy commented 7 years ago

Sounds good! Will make another PR, but for now I think the readme change is necessary because it does not work out of the box at all with the new django changes

On Wed, Apr 19, 2017 at 17:47 David Burke notifications@github.com wrote:

I'd rather have the action just magically appear. Maybe try to figure out why it's not working for you and see if there is a alternative.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/burke-software/django-mass-edit/pull/69#issuecomment-295458300, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7GthXdT0bkZESRxUVJgsPGaHrWtXPNks5rxoDqgaJpZM4Mu3lL .

namanshenoy commented 7 years ago

Besides, you need to add the urls anyway, so adding another line to the same file isn't really any different

bufke commented 7 years ago

I'm against adding speculation on a project's readme. If you find a way to make it "just work" or a specific reason on why the "just works" method isn't working for you we could add it to the readme. For that I'd like to see documentation proving that Django does not allow apps adding admin actions automatically.

If I had to guess - we probably just need to move the logic to somewhere like here.