Some love

[frnhr]

A bit of love for the project ❤️

New settings

django-mass-edit will now read MASSEDIT dict from project settings.

This are the defaults, not changing the current behavior:

MASSEDIT = {
    'ADD_ACTION_GLOBALLY': True,
    'SESSION_BASED_URL_THRESHOLD': 500,
}

Not adding the action to allthethings

'ADD_ACTION_GLOBALLY': False will prevent adding Mass Edit action to all models automatically. There is a tiny admin mixin added to do that manually for each model where desired.

Always use session-based URLs

Well, technically the change is to move the hardcoded 500 into settings, but I'm using 'SESSION_BASED_URL_THRESHOLD': 0, i.e. simply always using the session-based settings.

While 500 is a sensible default, since it only applies to the ids portion of the URL, sometimes other parts of the URL can make the total length spill over the limit (2k chars or something thereabout I think).

Compatibility with django-filer

The change class="form-row field-{{ field.field.name }} makes it compatible with django-filter. Just for some styles to catch on, already worked otherwise.

Tox

Added tox ¯\_(ツ)_/¯

Some typos and coding style

Not much, just a few details here and there...

Readme

Removed the step about adding eggs.Loader to TEMPLATE_LOADERS, not needed any more.

Also explained the new settings.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.5%) to 90.233% when pulling 6fce89e87cf5d23cb0e767b2e385edc1037f503a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[coveralls]

Coverage increased (+0.3%) to 90.0% when pulling 7a823e5337e199821262cc5aec441ee5bc6b119a on frnhr:app_settings into 9d33b92aadced58aa0ca028e89a0ec643858103b on burke-software:master.

[skyl]

This is the commit I use in production right now ...