burke / zeus

Boot any rails app in under a second.
MIT License
3.33k stars 231 forks source link

End-to-end integration test #549

Closed metcalf closed 8 years ago

metcalf commented 8 years ago

This adds an end-to-end integration test that:

The test is currently quite coarse and doesn't introspect much of what Zeus is doing. The goal is to have at least a basic sanity check before writing more detailed unit tests.

I was not able to get rubinius working inside of the Travis golang VM so I've dropped that from the build matrix but retained the other MRI ruby versions.

metcalf commented 8 years ago

r? @antifuchs

antifuchs commented 8 years ago

I really like this - hope it does succeed reliably. If not, I think we should do the three-phase socket interaction suggested above.

:+1: from me!

metcalf commented 8 years ago

OK, I'll push amended commits a few times to ensure we can get a nice long string of passes. If that doesn't work, I'll look into the STREAM approach.

metcalf commented 8 years ago

I wasn't able to get the test to pass reliably when changing two files. I reduced it to only changing a single .rb file and it nows seems to pass reliably. I'm going to land this and aim to improve things from there.

antifuchs commented 8 years ago

Thank you! I love tests (: