Remove use of global variables for configuration

burke / zeus

Boot any rails app in under a second.

MIT License

3.33k stars 231 forks source link

Remove use of global variables for configuration #564

Closed metcalf closed 8 years ago

metcalf commented 8 years ago

In several places, Zeus propogates configuration by mutating global variables. This makes packages harder to test and interfaces less clear. This PR replaces all mutable global variables with explicit local arguments.

metcalf commented 8 years ago

r? @ptarjan

ptarjan commented 8 years ago

lgtm

metcalf commented 8 years ago

Yeaa.... all those magic numbers were micro-optimizations that made tests run 1 second faster. Totally not worth the potential for confusion. I brought back the public DefaultFileChangeDelay and use that consistently.