Closed sideshowcoder closed 7 years ago
@latortuga @andrew-stripe not sure who would be good to have a look at this I haven't touched zeus in some time, but this was annoying so I thought I take a look. Would be awesome if one of you could have a look at my (probably pretty rusty) go.
@burke in case you want to take a look here as well.
I don't have time to review in depth today, but at a quick glance this looks sensible :+1:
No worries, seems like a minor change so I think its good.
When zeus has an error it is quite inconvinient to have it written to stdout as this easily hides problems. To resolve this we allow
shinylog
to log tostderr
for strings. As those are user facing error we want to hide the implementation detail of go so don't log error locations as they are most likely not helpful to the end user.fixes #612