Closed skytos closed 7 years ago
Makes a lot of sense to me. Not that well versed in RSpec but I'm wondering if there is a way to test this so we can avoid regression? Maybe have 2 Gemfiles one with RSpec 2 and one with RSpec 3 and run both on Travis?
Thanks for the work! I'm happy to merge this, would be even happier if we had a test 👍
I'll look into a way to test it. Maybe something like https://github.com/thoughtbot/appraisal can help? On Jan 12, 2017 6:59 AM, "Philipp Fehre" notifications@github.com wrote:
Makes a lot of sense to me. Not that well versed in RSpec but I'm wondering if there is a way to test this so we can avoid regression? Maybe have 2 Gemfiles one with RSpec 2 and one with RSpec 3 and run both on Travis?
Thanks for the work! I'm happy to merge this, would be even happier if we had a test 👍
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/burke/zeus/pull/618#issuecomment-272184753, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMa3-ZFhmpTH0fpFZcjoWYw8Q6Ec_0Kks5rRj_CgaJpZM4LhN4O .
Sounds reasonable, happy to try to help let me know how it goes.
fixes #588
I'm not coming up with any great ways to test this other than having a couple dummy apps that require zeus and different versions of rspec. I don't see how to integrate that with the current test setup since the tests are rspec tests themselves and they don't work with rspec2 syntax. I could add a new make task that test-rubygem depends upon but it seems pretty heavy weight. @sideshowcoder does that seem like a path worth pursuing or did you have another idea?
Well I think if it is to heavy weight I'm fine with just leaving it as is to be honest. :) Thanks for taking a looks so!
Description of Problem
zeus rspec
fails for rspec 2 since the invoke method does not exist on RSpec::Core::Runner until rspec 3System details
uname -a
: Darwin I.local 15.6.0 Darwin Kernel Version 15.6.0: Wed Nov 2 20:30:56 PDT 2016; root:xnu-3248.60.11.1.2~2/RELEASE_X86_64 x86_64ruby -v
: ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-darwin14.0]Steps to Reproduce
1)
zeus start
in a rails project with rails 22)
zeus rspec
Observed Behavior
Expected Behavior