search

burke / zeus

Boot any rails app in under a second.
MIT License
3.33k stars 231 forks source link

Support new Rails 5.1 command structure #640

Closed sideshowcoder closed 7 years ago

sideshowcoder commented 7 years ago

Fixes #634 based on suggestion by @server-monitor

server-monitor commented 7 years ago

That's awesome. I didn't even think about putting in logic to decide between versions > and < 5.1. There's one small typo though on the run_rails_5_1_or_higer_command method name. I think you meant run_rails_5_1_or_higher_command.

sideshowcoder commented 7 years ago

Oh yeah me can't type 👍 thanks for taking a look. When you have a chance to try it out to see if it works as expected I'd clean it up and would release a new version with the fix in the next days

iGEL commented 7 years ago

@sideshowcoder Thank you very much for this. Any chance for a new release soon? It's our only blocker for the Rails 5.1 update.

server-monitor commented 7 years ago

@iGEL It's already released. I tested it a few days ago.

sideshowcoder commented 7 years ago

Currently released as pre so yeah use it! :D